Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delete Client Indexing #79

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

Syasyazman
Copy link

Also re-added test cases for delete client and order.

@Syasyazman Syasyazman added type.Bug Something isn't working severity.Medium A bug that sometimes affect usage labels Oct 26, 2020
@Syasyazman Syasyazman added this to the v1.3 milestone Oct 26, 2020
@Syasyazman Syasyazman linked an issue Oct 26, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #79 into master will increase coverage by 3.91%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
+ Coverage     53.84%   57.76%   +3.91%     
- Complexity      399      428      +29     
============================================
  Files            90       91       +1     
  Lines          1679     1688       +9     
  Branches        173      174       +1     
============================================
+ Hits            904      975      +71     
+ Misses          727      661      -66     
- Partials         48       52       +4     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/AddressBook.java 74.60% <33.33%> (+23.78%) 21.00 <0.00> (+5.00)
...model/person/OrderIdContainsKeywordsPredicate.java 71.42% <71.42%> (ø) 2.00 <2.00> (?)
...rc/main/java/seedu/address/model/person/Order.java 46.66% <100.00%> (+46.66%) 4.00 <0.00> (+4.00)
...in/java/seedu/address/logic/parser/ParserUtil.java 80.00% <0.00%> (+4.00%) 16.00% <0.00%> (+1.00%)
...rc/main/java/seedu/address/model/ModelManager.java 85.71% <0.00%> (+7.93%) 26.00% <0.00%> (+3.00%)
...va/seedu/address/model/person/UniqueOrderList.java 43.90% <0.00%> (+21.95%) 10.00% <0.00%> (+5.00%)
...du/address/logic/commands/DeleteClientCommand.java 100.00% <0.00%> (+30.76%) 8.00% <0.00%> (+1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5522e6...a80d2e8. Read the comment docs.

@Syasyazman Syasyazman merged commit 2bc6bfc into AY2021S1-CS2103-F09-4:master Oct 26, 2020
@Syasyazman Syasyazman deleted the branch-delete branch October 26, 2020 08:21
@Syasyazman Syasyazman restored the branch-delete branch October 26, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Medium A bug that sometimes affect usage type.Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Delete Client Indexing
2 participants