Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Userguide, Ui.png and Sample Data #154

Merged
merged 6 commits into from
Oct 28, 2020
Merged

Update Userguide, Ui.png and Sample Data #154

merged 6 commits into from
Oct 28, 2020

Conversation

yejiadong
Copy link

@yejiadong yejiadong commented Oct 28, 2020

  • Updated Userguide with current find-training command implementation
  • Edited bugs in Userguide
  • Updated Ui.png to reflect latest GUI
  • Updated Sample Data to also add trainings and attendances for better testing experience

@yejiadong yejiadong added the documentation Improvements or additions to documentation label Oct 28, 2020
@yejiadong yejiadong added this to the v1.3b milestone Oct 28, 2020
@yejiadong yejiadong requested a review from a team October 28, 2020 11:11
@yejiadong yejiadong self-assigned this Oct 28, 2020
@yejiadong yejiadong added this to To do in CanoE-COACH via automation Oct 28, 2020
@yejiadong yejiadong moved this from To do to Done in CanoE-COACH Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #154 into master will decrease coverage by 0.89%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
- Coverage     69.12%   68.22%   -0.90%     
  Complexity      789      789              
============================================
  Files           122      122              
  Lines          2675     2710      +35     
  Branches        336      341       +5     
============================================
  Hits           1849     1849              
- Misses          702      737      +35     
  Partials        124      124              
Impacted Files Coverage Δ Complexity Δ
...c/main/java/seedu/canoe/model/student/Student.java 72.47% <0.00%> (-4.32%) 53.00 <0.00> (ø)
...in/java/seedu/canoe/model/util/SampleDataUtil.java 9.25% <0.00%> (-7.99%) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d4f60e...259ab4d. Read the comment docs.

@yejiadong yejiadong changed the title Update Userguide and Ui.png Update Userguide, Ui.png and Sample Data Oct 28, 2020
@yejiadong yejiadong added the enhancement New feature or request label Oct 28, 2020
Copy link

@sudogene sudogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejiadong yejiadong merged commit cda84e4 into master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
CanoE-COACH
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants