Add Academic Year to Student #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whleee
requested review from
yejiadong,
sudogene,
abdurrahmanfaqihiskandar and
kerkpy
| public class AcademicYear { | ||
|
|
||
| public static final String MESSAGE_CONSTRAINTS = | ||
| "The Academic Year should only contain a number between 1 to 5."; |
There was a problem hiding this comment.
Isn't this supposed to be 1 to 6?
There was a problem hiding this comment.
I checked the google docs and it said 1 to 5? hmm can someone confirm
| Permission is hereby granted, free of charge, to any student obtaining a copy | ||
| Permission is hereby granted, free of charge, to any person obtaining a copy |
There was a problem hiding this comment.
You need to update to student for this file.
There was a problem hiding this comment.
Ah that one is LICENSE, should stay as person
sudogene
reviewed
Sep 21, 2020
| * Parses a {@code String academicYear} into an {@code AcademicYear}. | ||
| * Leading and trailing whitespaces will be trimmed. | ||
| * | ||
| * @throws ParseException if the given {@code email} is invalid. |
This was
linked to
issues
Sep 24, 2020
yejiadong
pushed a commit
that referenced
this pull request
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.