Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Branch] Add Student Id field #68

Merged
merged 9 commits into from
Oct 8, 2020

Conversation

sudogene
Copy link

@sudogene sudogene commented Oct 8, 2020

Student Id is aimed to be a unique identifier of a student. The end goal is to have Id creation be automated and not part of the user input. Uniqueness of the value is done by the application, freeing user from the burden. This has not been implemented yet as of this mid iteration.

The Id field

  • String value, must be numeric
  • Padded with leading zeroes ONLY for UI display new Id("1") ==> "001"
  • Value itself has not been padded
  • CANNOT be edited, EditCommand does not support editing of Id

Current iteration for pre-mid-v1.2

  • Requires manual input from user add n/John Doe id/2 ...
  • Uniqueness of Id value has not been implemented yet

Additional feature

  • Able to find by student id find id/2

@sudogene sudogene requested review from Whleee and a team October 8, 2020 14:10
@yejiadong yejiadong added the enhancement New feature or request label Oct 8, 2020
@yejiadong yejiadong added this to To do in CanoE-COACH via automation Oct 8, 2020
@yejiadong yejiadong added this to the v1.2 milestone Oct 8, 2020
@yejiadong yejiadong moved this from To do to In Progress in CanoE-COACH Oct 8, 2020
Copy link

@yejiadong yejiadong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sudogene sudogene merged commit 061e0dc into AY2021S1-CS2103-F10-1:master Oct 8, 2020
@sudogene sudogene linked an issue Oct 8, 2020 that may be closed by this pull request
@abdurrahmanfaqihiskandar abdurrahmanfaqihiskandar moved this from In Progress to Done in CanoE-COACH Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
CanoE-COACH
  
Done
Development

Successfully merging this pull request may close these issues.

Add student Id to Student and Find by Id
2 participants