Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit commmand bugs #98

Merged

Conversation

abdurrahmanfaqihiskandar

Fixed 2 bugs:

  1. Editing other fields does not change the student's details in the training panel
  2. Changing one dismissal time to conflict with one training session, will make the other training
    sessions disappear from the GUI

@abdurrahmanfaqihiskandar abdurrahmanfaqihiskandar requested a review from a team October 15, 2020 16:06
@abdurrahmanfaqihiskandar abdurrahmanfaqihiskandar added this to To do in CanoE-COACH via automation Oct 15, 2020
@abdurrahmanfaqihiskandar abdurrahmanfaqihiskandar linked an issue Oct 15, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #98 into master will decrease coverage by 0.13%.
The diff coverage is 46.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
- Coverage     69.21%   69.07%   -0.14%     
  Complexity      664      664              
============================================
  Files           108      108              
  Lines          2212     2225      +13     
  Branches        261      262       +1     
============================================
+ Hits           1531     1537       +6     
- Misses          579      585       +6     
- Partials        102      103       +1     
Impacted Files Coverage Δ Complexity Δ
...n/java/seedu/canoe/logic/commands/EditCommand.java 79.38% <36.36%> (-3.95%) 12.00 <0.00> (ø)
...java/seedu/canoe/logic/commands/DeleteCommand.java 76.19% <100.00%> (+1.19%) 7.00 <0.00> (ø)
src/main/java/seedu/canoe/model/Model.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47eb83...0517fa7. Read the comment docs.

Copy link

@yejiadong yejiadong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yejiadong yejiadong merged commit 01effa3 into AY2021S1-CS2103-F10-1:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
CanoE-COACH
  
To do
Development

Successfully merging this pull request may close these issues.

Fix edit command bugs
3 participants