Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GUI for Module #109

Merged
merged 4 commits into from
Oct 12, 2020

Conversation

nopenotj
Copy link

resolves #108

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #109 into master will decrease coverage by 1.39%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #109      +/-   ##
============================================
- Coverage     60.96%   59.56%   -1.40%     
  Complexity      477      477              
============================================
  Files            93       96       +3     
  Lines          1747     1788      +41     
  Branches        207      211       +4     
============================================
  Hits           1065     1065              
- Misses          597      638      +41     
  Partials         85       85              
Impacted Files Coverage Δ Complexity Δ
...n/java/seedu/address/commons/core/GuiSettings.java 69.23% <ø> (ø) 5.00 <0.00> (ø)
...rc/main/java/seedu/address/logic/LogicManager.java 52.94% <0.00%> (-11.35%) 3.00 <0.00> (ø)
...c/main/java/seedu/address/model/module/Module.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/MeetingCard.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...c/main/java/seedu/address/ui/MeetingListPanel.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/ui/ModuleCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rc/main/java/seedu/address/ui/ModuleListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf23167...fc253c3. Read the comment docs.

Copy link

@EkamSinghPandher EkamSinghPandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EkamSinghPandher EkamSinghPandher merged commit 645d00a into AY2021S1-CS2103-F10-2:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create GUI for Modules
3 participants