Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple tests for meeting #121

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

nopenotj
Copy link

resolves #117

@nopenotj nopenotj requested a review from gloon99 October 14, 2020 17:02
@codecov-io
Copy link

Codecov Report

Merging #121 into master will increase coverage by 1.03%.
The diff coverage is 23.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #121      +/-   ##
============================================
+ Coverage     51.77%   52.81%   +1.03%     
- Complexity      507      532      +25     
============================================
  Files           110      112       +2     
  Lines          2200     2240      +40     
  Branches        278      281       +3     
============================================
+ Hits           1139     1183      +44     
+ Misses          968      956      -12     
- Partials         93      101       +8     
Impacted Files Coverage Δ Complexity Δ
...eedu/address/logic/commands/ListModuleCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../address/logic/parser/ListModuleCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/seedu/address/logic/parser/ModuleBookParser.java 15.38% <0.00%> (-1.29%) 2.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 61.85% <0.00%> (+0.05%) 28.00 <0.00> (+2.00)
src/main/java/seedu/address/model/ModuleBook.java 51.85% <0.00%> (-2.00%) 8.00 <0.00> (ø)
...a/seedu/address/model/module/UniqueModuleList.java 31.81% <0.00%> (-0.74%) 7.00 <0.00> (ø)
...ss/model/person/PersonHasTagsAndNamePredicate.java 36.36% <0.00%> (-3.64%) 3.00 <0.00> (ø)
...u/address/model/person/PersonHasTagsPredicate.java 42.85% <0.00%> (-7.15%) 2.00 <0.00> (ø)
...eedu/address/logic/commands/AddMeetingCommand.java 43.18% <100.00%> (+43.18%) 9.00 <1.00> (+9.00)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47c86e...04ded50. Read the comment docs.

Copy link

@gloon99 gloon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gloon99 gloon99 merged commit 952856e into AY2021S1-CS2103-F10-2:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing for meetings
3 participants