Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend delete command #156

Merged
merged 6 commits into from
Oct 26, 2020
Merged

Extend delete command #156

merged 6 commits into from
Oct 26, 2020

Conversation

jerrylchong
Copy link

fix #125

Extend delete command to accept names, tags and module names as arguments.

Contacts who have the given names, tags, or are in the given modules will be deleted.

@jerrylchong jerrylchong added this to the v1.3b milestone Oct 26, 2020
@codecov-io
Copy link

codecov-io commented Oct 26, 2020

Codecov Report

Merging #156 into master will increase coverage by 0.71%.
The diff coverage is 70.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     50.49%   51.20%   +0.71%     
- Complexity      609      622      +13     
============================================
  Files           119      119              
  Lines          2745     2777      +32     
  Branches        372      391      +19     
============================================
+ Hits           1386     1422      +36     
+ Misses         1207     1190      -17     
- Partials        152      165      +13     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
.../seedu/address/logic/parser/CopyCommandParser.java 65.62% <33.33%> (+1.56%) 12.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 54.00% <38.88%> (+4.75%) 35.00 <3.00> (+4.00)
...eedu/address/logic/parser/DeleteCommandParser.java 72.41% <73.68%> (-27.59%) 16.00 <15.00> (+14.00) ⬇️
...va/seedu/address/logic/commands/DeleteCommand.java 86.95% <84.21%> (-5.36%) 10.00 <4.00> (-1.00)
.../seedu/address/logic/commands/AddLabelCommand.java 78.72% <100.00%> (+9.08%) 10.00 <0.00> (-1.00) ⬆️
...eedu/address/logic/commands/ClearLabelCommand.java 76.00% <100.00%> (+14.23%) 7.00 <0.00> (-1.00) ⬆️
...edu/address/logic/commands/DeleteLabelCommand.java 85.71% <100.00%> (+16.26%) 9.00 <0.00> (-1.00) ⬆️
...java/seedu/address/logic/commands/EditCommand.java 95.52% <100.00%> (-0.54%) 13.00 <0.00> (-2.00)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacbdf7...06befd5. Read the comment docs.

Copy link

@EkamSinghPandher EkamSinghPandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EkamSinghPandher EkamSinghPandher merged commit 92f4c78 into master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend delete command
3 participants