Add reassign command #107
Merged
Add reassign command #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakululuu
reviewed
Oct 27, 2020
| @@ -14,6 +14,7 @@ | |||
| import seedu.address.logic.commands.exceptions.CommandException; | |||
| import seedu.address.model.Model; | |||
| import seedu.address.model.assignment.Assignment; | |||
| //import seedu.address.model.assignment.exceptions.AssignmentNotFoundException; | |||
There was a problem hiding this comment.
Maybe this can be removed if it's not needed.
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Reassigns a worker to a new shift in the " | ||
| + "McScheduler by the index numbers used in the last worker and shift listings. " | ||
| + "\nParameters: " | ||
| + PREFIX_WORKER + "WORKER_INDEX (must be a positive integer) " |
There was a problem hiding this comment.
Would it be possible to allow the editing of the worker as well?
There was a problem hiding this comment.
Good point, will make the change!
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
============================================
+ Coverage 59.26% 65.89% +6.63%
- Complexity 580 651 +71
============================================
Files 119 119
Lines 2251 2290 +39
Branches 264 276 +12
============================================
+ Hits 1334 1509 +175
+ Misses 846 703 -143
- Partials 71 78 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reassigncommand acts as an 'assignment edit'. Callingreassignedits the Worker, Shift and Role of an Assignment.Testing will be added in separate PR
Resolves #92