Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tag class and make Role class standalone from Tag #129

Merged
merged 5 commits into from
Oct 29, 2020

Conversation

plosslaw
Copy link

Resolves #106

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #129 into master will decrease coverage by 0.05%.
The diff coverage is 72.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
- Coverage     69.82%   69.77%   -0.06%     
+ Complexity      863      854       -9     
============================================
  Files           139      137       -2     
  Lines          2993     2971      -22     
  Branches        411      408       -3     
============================================
- Hits           2090     2073      -17     
+ Misses          778      775       -3     
+ Partials        125      123       -2     
Impacted Files Coverage Δ Complexity Δ
...java/mcscheduler/logic/commands/AssignCommand.java 90.38% <ø> (ø) 14.00 <0.00> (ø)
...mcscheduler/logic/commands/CancelLeaveCommand.java 89.74% <ø> (ø) 12.00 <0.00> (ø)
...n/java/mcscheduler/logic/commands/CommandUtil.java 88.46% <ø> (ø) 12.00 <0.00> (ø)
...scheduler/logic/commands/MassTakeLeaveCommand.java 95.74% <ø> (ø) 17.00 <0.00> (ø)
...va/mcscheduler/logic/commands/ReassignCommand.java 77.58% <ø> (ø) 15.00 <0.00> (ø)
...ava/mcscheduler/logic/commands/RoleAddCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../mcscheduler/logic/commands/RoleDeleteCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...va/mcscheduler/logic/commands/RoleListCommand.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...a/mcscheduler/logic/commands/ShiftEditCommand.java 62.50% <ø> (ø) 15.00 <0.00> (ø)
...a/mcscheduler/logic/commands/TakeLeaveCommand.java 100.00% <ø> (ø) 9.00 <0.00> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f07690...edb4251. Read the comment docs.

Copy link

@WangZijun97 WangZijun97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In future can consider adding tests to ParserUtil for all our various added parser methods.

@WangZijun97 WangZijun97 merged commit 307f4b7 into AY2021S1-CS2103-F10-4:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Tag class
3 participants