Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #204

Merged
merged 9 commits into from
Nov 5, 2020
Merged

Conversation

plosslaw
Copy link

@plosslaw plosslaw commented Nov 5, 2020

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #204 into master will decrease coverage by 0.02%.
The diff coverage is 65.51%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
- Coverage     67.59%   67.56%   -0.03%     
- Complexity      859      866       +7     
============================================
  Files           141      141              
  Lines          3135     3179      +44     
  Branches        434      442       +8     
============================================
+ Hits           2119     2148      +29     
- Misses          890      904      +14     
- Partials        126      127       +1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/mcscheduler/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...heduler/logic/commands/WorkerAvailableCommand.java 27.45% <0.00%> (ø) 9.00 <0.00> (ø)
...a/mcscheduler/model/assignment/WorkerRolePair.java 76.00% <ø> (ø) 11.00 <0.00> (ø)
.../java/mcscheduler/model/shift/RoleRequirement.java 90.90% <ø> (ø) 21.00 <0.00> (ø)
src/main/java/mcscheduler/ui/ShiftCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/mcscheduler/ui/WorkerCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/mcscheduler/logic/parser/ParserUtil.java 59.23% <28.57%> (-3.63%) 26.00 <0.00> (ø)
...va/mcscheduler/logic/parser/McSchedulerParser.java 65.30% <100.00%> (+18.24%) 18.00 <0.00> (+6.00)
src/main/java/mcscheduler/model/worker/Phone.java 81.81% <100.00%> (+1.81%) 7.00 <1.00> (+1.00)
src/main/java/mcscheduler/model/worker/Worker.java 96.55% <100.00%> (ø) 27.00 <0.00> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613048b...158a605. Read the comment docs.

@plosslaw plosslaw added this to the v1.4 milestone Nov 5, 2020
Copy link

@sigmund-c sigmund-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@plosslaw plosslaw marked this pull request as draft November 5, 2020 14:34
@plosslaw plosslaw marked this pull request as ready for review November 5, 2020 14:40
@plosslaw plosslaw merged commit 8f18ade into AY2021S1-CS2103-F10-4:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment