Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Shift model classes #50

Merged
merged 9 commits into from
Oct 14, 2020

Conversation

WangZijun97
Copy link

@WangZijun97 WangZijun97 commented Oct 14, 2020

Tests added for the following classes:

  • Shift
  • ShiftDay
  • ShiftTime
  • RoleRequirements
  • Role
  • UniqueShiftList
  • ShiftDayOrTimeContainsKeywordPredicate

which should cover testing for seedu.address.model.shift sufficiently.

Relevant to #43 and builds upon PR #49

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@eba28f1). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #50   +/-   ##
=========================================
  Coverage          ?   65.17%           
  Complexity        ?      509           
=========================================
  Files             ?       92           
  Lines             ?     1720           
  Branches          ?      195           
=========================================
  Hits              ?     1121           
  Misses            ?      554           
  Partials          ?       45           
Impacted Files Coverage Δ Complexity Δ
...ava/seedu/address/model/shift/RoleRequirement.java 78.57% <ø> (ø) 15.00 <0.00> (?)
src/main/java/seedu/address/model/AddressBook.java 86.36% <100.00%> (ø) 19.00 <5.00> (?)
...rc/main/java/seedu/address/model/ModelManager.java 92.06% <100.00%> (ø) 28.00 <0.00> (?)
...shift/ShiftDayOrTimeContainsKeywordsPredicate.java 100.00% <100.00%> (ø) 9.00 <9.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba28f1...ca73664. Read the comment docs.

@plosslaw plosslaw merged commit 9652f26 into AY2021S1-CS2103-F10-4:master Oct 14, 2020
@WangZijun97 WangZijun97 added this to the v1.2 milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants