-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust ui: colors, jingle, icon, fix whitespace #98
Conversation
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
============================================
- Coverage 59.26% 59.02% -0.24%
Complexity 580 580
============================================
Files 119 120 +1
Lines 2251 2260 +9
Branches 264 264
============================================
Hits 1334 1334
- Misses 846 855 +9
Partials 71 71
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly a bug, also do update with the master
branch (can be done after the rest of 1.3 is ready since this is the last update to be merged).
src/main/resources/view/McTheme2.css
Outdated
@@ -0,0 +1,393 @@ | |||
.background { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file the alternative color scheme? Maybe can make use of UserPrefs
to allow users to switch to this. Also would be good if the duplicates in the two themes are condensed into one place so that we don't need to edit both when including new GUI elements. Otherwise there will be two representations of some parts of our GUI styling.
#shiftAssignments .label, | ||
#workerAssignments .label, | ||
#unavailableTiming .label, | ||
#leaveShiftAssignments .label, | ||
#leaveWorkerAssignments .label { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated with current master
branch code.
@@ -0,0 +1,24 @@ | |||
package seedu.address.ui; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if its because of my system but the jingle seems to get cut off halfway through when playing on startup.
…into ui-adjustments
…into ui-adjustments # Conflicts: # src/main/java/mcscheduler/ui/JinglePlayer.java
*ps. This PR is gonna be a bit annoying, sorry
Fixes #61
Added McDonald's Jingle (annoying part) #67
Changed GUI to white/yellow/red (also annoying) #69
Changed app icon to McD's #71