Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UnassignCommand #114

Conversation

florenciamartina
Copy link
Collaborator

Fixes #100

@florenciamartina florenciamartina added this to the v1.3 milestone Oct 20, 2020
@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #114 into master will increase coverage by 0.28%.
The diff coverage is 60.37%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #114      +/-   ##
============================================
+ Coverage     73.77%   74.06%   +0.28%     
- Complexity      655      692      +37     
============================================
  Files           102      106       +4     
  Lines          1880     1951      +71     
  Branches        220      230      +10     
============================================
+ Hits           1387     1445      +58     
- Misses          428      435       +7     
- Partials         65       71       +6     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 81.48% <0.00%> (-3.14%) 18.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 87.83% <0.00%> (-2.31%) 32.00 <0.00> (+1.00) ⬇️
...c/main/java/seedu/address/model/module/Module.java 81.08% <25.00%> (-6.80%) 18.00 <1.00> (+1.00) ⬇️
src/main/java/seedu/address/model/AddressBook.java 70.58% <33.33%> (-2.33%) 19.00 <1.00> (+1.00) ⬇️
...a/seedu/address/model/module/UniqueModuleList.java 66.66% <55.55%> (+1.58%) 26.00 <2.00> (+4.00)
.../seedu/address/logic/commands/UnassignCommand.java 73.91% <73.91%> (ø) 10.00 <10.00> (?)
...du/address/logic/parser/UnassignCommandParser.java 80.00% <80.00%> (ø) 2.00 <2.00> (?)
.../seedu/address/logic/parser/FindCommandParser.java 86.84% <0.00%> (-2.91%) 16.00% <0.00%> (-1.00%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd86ff...f77484d. Read the comment docs.

Copy link

@justintzuriel justintzuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, other than that LGTM

src/main/java/seedu/address/commons/core/Messages.java Outdated Show resolved Hide resolved
@justintzuriel justintzuriel merged commit 0501e31 into AY2021S1-CS2103-T14-1:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement unassign
3 participants