Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UnassignallCommand #115

Conversation

florenciamartina
Copy link
Collaborator

Fixes #102

@florenciamartina florenciamartina added this to the v1.3 milestone Oct 20, 2020
@codecov-io
Copy link

codecov-io commented Oct 20, 2020

Codecov Report

Merging #115 into master will increase coverage by 1.53%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #115      +/-   ##
============================================
+ Coverage     72.37%   73.90%   +1.53%     
- Complexity      570      662      +92     
============================================
  Files            95      103       +8     
  Lines          1716     1901     +185     
  Branches        195      220      +25     
============================================
+ Hits           1242     1405     +163     
- Misses          423      431       +8     
- Partials         51       65      +14     
Impacted Files Coverage Δ Complexity Δ
.../seedu/address/logic/parser/AddressBookParser.java 81.48% <0.00%> (+1.48%) 18.00 <0.00> (+2.00)
src/main/java/seedu/address/model/AddressBook.java 74.00% <0.00%> (+2.26%) 19.00 <0.00> (+2.00)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...rc/main/java/seedu/address/ui/PersonListPanel.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...edu/address/logic/commands/UnassignallCommand.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...rc/main/java/seedu/address/model/ModelManager.java 90.66% <100.00%> (+0.96%) 32.00 <1.00> (+3.00)
...c/main/java/seedu/address/model/module/Module.java 88.88% <100.00%> (+0.65%) 18.00 <1.00> (-2.00) ⬆️
...a/seedu/address/model/module/UniqueModuleList.java 67.64% <100.00%> (+2.56%) 24.00 <2.00> (+2.00)
...edu/address/logic/parser/FindModCommandParser.java 80.00% <0.00%> (-20.00%) 8.00% <0.00%> (+5.00%) ⬇️
...a/seedu/address/logic/commands/FindModCommand.java 82.60% <0.00%> (-17.40%) 11.00% <0.00%> (+5.00%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0020a...bc566b4. Read the comment docs.

Copy link

@justintzuriel justintzuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justintzuriel justintzuriel merged commit 9143c60 into AY2021S1-CS2103-T14-1:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement unassignall
3 participants