Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in list command #123

Conversation

florenciamartina
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 21, 2020

Codecov Report

Merging #123 into master will increase coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
+ Coverage     74.22%   74.25%   +0.02%     
- Complexity      700      704       +4     
============================================
  Files           107      108       +1     
  Lines          1971     1977       +6     
  Branches        230      231       +1     
============================================
+ Hits           1463     1468       +5     
  Misses          437      437              
- Partials         71       72       +1     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...java/seedu/address/logic/commands/ListCommand.java 83.33% <0.00%> (-16.67%) 3.00 <1.00> (+1.00) ⬇️
.../seedu/address/logic/parser/AddressBookParser.java 78.57% <0.00%> (ø) 18.00 <0.00> (ø)
.../seedu/address/logic/parser/ListCommandParser.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0833abd...0bb3bb4. Read the comment docs.

Copy link
Collaborator

@erinmayg erinmayg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a few minor changes, LGTM! 😄

Copy link
Collaborator

@drake25122000 drake25122000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erinmayg erinmayg merged commit ad9676c into AY2021S1-CS2103-T14-1:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants