Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests and fix bugs in UnassignCommandTest #135

Conversation

florenciamartina
Copy link
Collaborator

@florenciamartina florenciamartina commented Oct 21, 2020

Fixes #116

@erinmayg erinmayg marked this pull request as draft October 21, 2020 19:45
@florenciamartina florenciamartina marked this pull request as ready for review October 21, 2020 20:55
@florenciamartina florenciamartina changed the title Update tests in UnassignCommandTest Update tests and fix bugs in UnassignCommandTest Oct 22, 2020
@codecov-io
Copy link

codecov-io commented Oct 22, 2020

Codecov Report

Merging #135 into master will increase coverage by 0.18%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #135      +/-   ##
============================================
+ Coverage     74.09%   74.27%   +0.18%     
- Complexity      713      719       +6     
============================================
  Files           109      109              
  Lines          1984     1998      +14     
  Branches        231      236       +5     
============================================
+ Hits           1470     1484      +14     
- Misses          444      445       +1     
+ Partials         70       69       -1     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...a/seedu/address/model/module/UniqueModuleList.java 61.90% <57.14%> (-6.93%) 28.00 <2.00> (ø)
.../seedu/address/logic/commands/UnassignCommand.java 92.30% <100.00%> (+19.58%) 13.00 <0.00> (+3.00)
src/main/java/seedu/address/model/AddressBook.java 71.92% <100.00%> (-0.80%) 21.00 <1.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 88.75% <100.00%> (+0.28%) 34.00 <1.00> (+1.00)
...c/main/java/seedu/address/model/module/Module.java 94.87% <100.00%> (+12.37%) 21.00 <1.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc409ec...52463a3. Read the comment docs.

Copy link
Collaborator

@erinmayg erinmayg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested 😄

src/main/java/seedu/address/model/AddressBook.java Outdated Show resolved Hide resolved
@jzwoo jzwoo merged commit 430a332 into AY2021S1-CS2103-T14-1:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish tests for UnassignCommand
4 participants