Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edited person bug for both semesters #172

Conversation

erinmayg
Copy link
Collaborator

Fix #170

@codecov-io
Copy link

Codecov Report

Merging #172 into master will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #172      +/-   ##
============================================
- Coverage     73.53%   73.32%   -0.21%     
  Complexity      744      744              
============================================
  Files           110      110              
  Lines          2101     2107       +6     
  Branches        254      256       +2     
============================================
  Hits           1545     1545              
- Misses          474      479       +5     
- Partials         82       83       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/AddressBook.java 56.25% <0.00%> (-3.75%) 27.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4686fcb...def714e. Read the comment docs.

Copy link

@justintzuriel justintzuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justintzuriel justintzuriel merged commit a1e40dd into AY2021S1-CS2103-T14-1:master Oct 27, 2020
@erinmayg erinmayg added this to the v1.3 milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix edit not updating instructor list in non-active semester
3 participants