Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #242

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Conversation

jzwoo
Copy link
Collaborator

@jzwoo jzwoo commented Nov 7, 2020

Additional tests have been added to:

OneWordCommandParserTest
FindModCommandParserTest
FindCommandParserTest
AssignCommandParserTest
AddressBookParserTest
AddModCommandParserTest
FindModCommandTest
FindCommandTest

Fixes #238

Additional tests have been added to:
OneWordCommandParserTest
FindModCommandParserTest
FindCommandParserTest
AssignCommandParserTest
AddressBookParserTest
AddModCommandParserTest
FindModCommandTest
FindCommandTest
@codecov-io
Copy link

Codecov Report

Merging #242 (df50736) into master (4fbcfac) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
+ Coverage     72.87%   72.96%   +0.08%     
- Complexity      762      776      +14     
============================================
  Files           109      109              
  Lines          2205     2212       +7     
  Branches        275      275              
============================================
+ Hits           1607     1614       +7     
+ Misses          506      502       -4     
- Partials         92       96       +4     
Impacted Files Coverage Δ Complexity Δ
...va/seedu/address/logic/commands/CclearCommand.java 85.71% <0.00%> (-14.29%) 4.00 <1.00> (+1.00) ⬇️
...ava/seedu/address/logic/commands/ClistCommand.java 80.00% <0.00%> (-20.00%) 3.00 <1.00> (+1.00) ⬇️
...java/seedu/address/logic/commands/ExitCommand.java 66.66% <0.00%> (-33.34%) 3.00 <1.00> (+1.00) ⬇️
...java/seedu/address/logic/commands/HelpCommand.java 66.66% <0.00%> (-33.34%) 3.00 <1.00> (+1.00) ⬇️
...va/seedu/address/logic/commands/MclearCommand.java 85.71% <0.00%> (-14.29%) 4.00 <1.00> (+1.00) ⬇️
...ava/seedu/address/logic/commands/MlistCommand.java 80.00% <0.00%> (-20.00%) 3.00 <1.00> (+1.00) ⬇️
...ava/seedu/address/logic/commands/ResetCommand.java 80.00% <0.00%> (-20.00%) 3.00 <1.00> (+1.00) ⬇️
.../seedu/address/logic/parser/FindCommandParser.java 83.78% <0.00%> (+2.70%) 19.00% <0.00%> (+4.00%)
...edu/address/logic/parser/OneWordCommandParser.java 92.00% <0.00%> (+4.00%) 22.00% <0.00%> (+1.00%)
...edu/address/logic/parser/FindModCommandParser.java 88.88% <0.00%> (+14.81%) 12.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbcfac...df50736. Read the comment docs.

@jzwoo jzwoo added this to the v1.4 milestone Nov 7, 2020
Copy link

@justintzuriel justintzuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justintzuriel justintzuriel merged commit 9e41f9d into AY2021S1-CS2103-T14-1:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional tests
3 participants