Add department attribute and delete address attribute #60

drake25122000 · 2020-10-01T14:12:43Z

Fixes #59 , fixes #54 , fixes #52

justintzuriel

Changes to department names and fixes to minor typos requested

src/main/java/seedu/address/model/AddressBook.java

src/test/java/seedu/address/logic/commands/CommandTestUtil.java

src/test/java/seedu/address/model/person/NameContainsKeywordsPredicateTest.java

src/test/java/seedu/address/model/person/PersonTest.java

src/test/java/seedu/address/logic/commands/CommandTestUtil.java

src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json

src/main/java/seedu/address/model/util/SampleDataUtil.java

src/main/java/seedu/address/logic/commands/AddCommand.java

justintzuriel

Minor edits to be made

src/test/java/seedu/address/testutil/TypicalPersons.java

src/test/java/seedu/address/model/person/PersonTest.java

justintzuriel

LGTM

drake25122000 added 5 commits October 1, 2020 22:09

Add department attribute

ac5386a

Fix LineLenght error

23f1b48

Fix another LineLenght error

5a1b82d

Fix error '+' placement

465faee

Fix test

88bd5c1

justintzuriel requested changes Oct 1, 2020

View reviewed changes

drake25122000 added 3 commits October 1, 2020 23:48

Fix minor errors

489a224

Fix error

395709b

Fix error

fac16e0

justintzuriel requested changes Oct 1, 2020

View reviewed changes

src/test/java/seedu/address/testutil/TypicalPersons.java Outdated Show resolved Hide resolved

src/test/java/seedu/address/model/person/PersonTest.java Outdated Show resolved Hide resolved

Fix minor problems

210b1cd

justintzuriel approved these changes Oct 1, 2020

View reviewed changes

justintzuriel merged commit aa6d374 into AY2021S1-CS2103-T14-1:master Oct 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add department attribute and delete address attribute #60

Add department attribute and delete address attribute #60

drake25122000 commented Oct 1, 2020 •

edited by justintzuriel

justintzuriel left a comment

justintzuriel left a comment

justintzuriel left a comment

Add department attribute and delete address attribute #60

Add department attribute and delete address attribute #60

Conversation

drake25122000 commented Oct 1, 2020 • edited by justintzuriel

justintzuriel left a comment

Choose a reason for hiding this comment

justintzuriel left a comment

Choose a reason for hiding this comment

justintzuriel left a comment

Choose a reason for hiding this comment

drake25122000 commented Oct 1, 2020 •

edited by justintzuriel