Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "clear" to "reset" and add new commands #90

Conversation

florenciamartina
Copy link
Collaborator

Fixes #79

@codecov-io
Copy link

codecov-io commented Oct 12, 2020

Codecov Report

Merging #90 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #90      +/-   ##
============================================
- Coverage     73.98%   73.62%   -0.37%     
- Complexity      461      525      +64     
============================================
  Files            77       87      +10     
  Lines          1357     1596     +239     
  Branches        145      180      +35     
============================================
+ Hits           1004     1175     +171     
- Misses          312      368      +56     
- Partials         41       53      +12     
Impacted Files Coverage Δ Complexity Δ
.../seedu/address/logic/parser/AddressBookParser.java 80.00% <0.00%> (-20.00%) 12.00% <0.00%> (ø%)
src/main/java/seedu/address/model/AddressBook.java 75.60% <0.00%> (-16.06%) 16.00% <0.00%> (+4.00%) ⬇️
...rc/main/java/seedu/address/model/ModelManager.java 91.37% <0.00%> (-8.63%) 26.00% <0.00%> (+3.00%) ⬇️
...rc/main/java/seedu/address/logic/LogicManager.java 71.42% <0.00%> (-3.58%) 3.00% <0.00%> (ø%)
src/main/java/seedu/address/model/Model.java 100.00% <0.00%> (ø) 1.00% <0.00%> (ø%)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...c/main/java/seedu/address/model/person/Person.java 100.00% <0.00%> (ø) 25.00% <0.00%> (+1.00%)
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <0.00%> (ø) 14.00% <0.00%> (+1.00%)
...a/seedu/address/logic/parser/AddCommandParser.java 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa6d84...f33d602. Read the comment docs.

docs/UserGuide.md Outdated Show resolved Hide resolved
Assigns a professor to a module.

Format: `assign INDEX m/MODULE_CODE [MORE MODULE_CODES]`
* Assigns all the `MODULE_CODE` to the contact at the specified `INDEX`. All of the `MODULE_CODE` **must exist** in FaculType in the first place.
Copy link
Collaborator

@jzwoo jzwoo Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm for this part is it better to say "Assigns the contact/instructor at the specified index to the module code"? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes. Can you check it again? thanks.

Copy link
Collaborator

@erinmayg erinmayg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justintzuriel justintzuriel merged commit f2422fd into AY2021S1-CS2103-T14-1:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs
5 participants