Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MClearCommand #93

Conversation

drake25122000
Copy link
Collaborator

Fixes #81

Copy link
Collaborator

@erinmayg erinmayg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a (very) minor mistake, LGTM!

src/main/java/seedu/address/model/Model.java Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #93 into master will increase coverage by 0.16%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #93      +/-   ##
============================================
+ Coverage     74.58%   74.75%   +0.16%     
- Complexity      562      570       +8     
============================================
  Files            92       93       +1     
  Lines          1645     1660      +15     
  Branches        185      186       +1     
============================================
+ Hits           1227     1241      +14     
- Misses          367      368       +1     
  Partials         51       51              
Impacted Files Coverage Δ Complexity Δ
.../seedu/address/logic/parser/AddressBookParser.java 83.33% <0.00%> (-3.63%) 16.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...va/seedu/address/logic/commands/MClearCommand.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/main/java/seedu/address/model/AddressBook.java 76.74% <100.00%> (+1.13%) 17.00 <1.00> (+1.00)
...rc/main/java/seedu/address/model/ModelManager.java 92.30% <100.00%> (+0.37%) 29.00 <2.00> (+2.00)
...a/seedu/address/model/module/UniqueModuleList.java 75.92% <100.00%> (+1.41%) 22.00 <2.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc8f84...00daacd. Read the comment docs.

Copy link

@justintzuriel justintzuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

src/main/java/seedu/address/model/AddressBook.java Outdated Show resolved Hide resolved
Copy link

@justintzuriel justintzuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justintzuriel justintzuriel merged commit b2dfbdf into AY2021S1-CS2103-T14-1:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement mclear
4 participants