Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies in naming and ordering #95

Conversation

florenciamartina
Copy link
Collaborator

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 13, 2020

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #95   +/-   ##
=========================================
  Coverage     74.31%   74.31%           
  Complexity      553      553           
=========================================
  Files            90       90           
  Lines          1635     1635           
  Branches        185      185           
=========================================
  Hits           1215     1215           
  Misses          369      369           
  Partials         51       51           
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 91.93% <ø> (ø) 27.00 <0.00> (ø)
...va/seedu/address/logic/commands/DelModCommand.java 84.61% <100.00%> (ø) 5.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1595bee...0993450. Read the comment docs.

Copy link

@justintzuriel justintzuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to be made

src/main/java/seedu/address/model/Model.java Outdated Show resolved Hide resolved
Copy link
Collaborator

@erinmayg erinmayg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@justintzuriel justintzuriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justintzuriel justintzuriel merged commit 683ef75 into AY2021S1-CS2103-T14-1:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants