Delete ab3 code #136
Merged
Delete ab3 code #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lyeyixian
requested review from
jiaweiteo,
underthehai,
jeannetoh99 and
timjkong
# Conflicts: # src/main/java/seedu/address/logic/wanderlustlogic/wanderlustparser/CliSyntax.java
# Conflicts: # src/main/java/seedu/address/logic/wanderlustlogic/Logic.java # src/main/java/seedu/address/logic/wanderlustlogic/wanderlustparser/WanderlustGoToCommandParser.java # src/main/java/seedu/address/logic/wanderlustlogic/wanderlustparser/WanderlustParser.java # src/test/java/seedu/address/logic/parser/DeleteCommandParserTest.java # src/test/java/seedu/address/logic/wanderlustlogic/wanderlustcommands/GoToCommandTest.java
jeannetoh99
reviewed
Oct 19, 2020
| @@ -94,6 +94,7 @@ public Directory getDirectory() { | |||
| return model.getDirectory(); | |||
| } | |||
|
|
|||
| // TODO: | |||
There was a problem hiding this comment.
Just clarifying here, what's there TODO here?
There was a problem hiding this comment.
oh cos this method is I cincai add one last time. No JavaDoc all that, need to redo
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
============================================
- Coverage 70.76% 67.26% -3.51%
+ Complexity 1061 764 -297
============================================
Files 164 116 -48
Lines 3270 2456 -814
Branches 410 302 -108
============================================
- Hits 2314 1652 -662
+ Misses 820 681 -139
+ Partials 136 123 -13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But still have some issue