Update DG: Find #141
Merged
Update DG: Find #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I think the commit is messed up, cos I branch this from the branch where I updated the Design section. So, this PR includes both changes. RIP |
jeannetoh99
approved these changes
Oct 21, 2020
| * loops through the **keywords** (of type `List<String>`) and return true if there is any match with the `Nameable` | ||
|
|
||
| `Nameable` provides the following operation: | ||
| * `Nameable#getName()` - Return the name attribute of a `TravelPlanObject` |
There was a problem hiding this comment.
Returns instead of Return? And not sure if there should be a full stop here.
| `Predicate<Nameable>` and has the **test** method overriden with a custom implementations. | ||
|
|
||
| The `NameContainsKeywordsPredicate#test(Nameable)` is as follows: | ||
| * loops through the **keywords** (of type `List<String>`) and return true if there is any match with the `Nameable` |
There was a problem hiding this comment.
Not sure if there should be a full stop here.
There was a problem hiding this comment.
Should it be:
- loops through the keywords (of type
List<String>) and return true if there is any match withNameable.getName().name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HALPPPP!!