Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EditCommand in Developer Guide #145

Merged
merged 13 commits into from
Oct 22, 2020

Conversation

underthehai
Copy link
Collaborator

No description provided.

Copy link

@jiaweiteo jiaweiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor change to the "same" definition.

- `EditTravelPlanCommand`

`EditCommand` accounts for duplicated objects.
Two objects are considered the same when they have the same name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the accomodation class requires start date and end date to be the same too for two accommodation object to be the same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, travelplan too. I updated them

Copy link
Collaborator

@lyeyixian lyeyixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lyeyixian lyeyixian linked an issue Oct 22, 2020 that may be closed by this pull request
@lyeyixian lyeyixian added this to the v1.3 milestone Oct 22, 2020
@underthehai underthehai merged commit 6e4b286 into AY2021S1-CS2103-T14-3:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DG: Edit
3 participants