Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete AB3 documentation in DG #146

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

underthehai
Copy link
Collaborator

Update glossary
Fix DeleteSequenceDiagram.png issues
Shift layout in UiClassDiagram

@codecov-io
Copy link

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #146   +/-   ##
=========================================
  Coverage     66.68%   66.68%           
  Complexity      765      765           
=========================================
  Files           116      116           
  Lines          2491     2491           
  Branches        307      307           
=========================================
  Hits           1661     1661           
  Misses          706      706           
  Partials        124      124           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d569a37...cbac8b2. Read the comment docs.

@@ -59,7 +59,7 @@ The sections below give more details of each component.

### UI component

![Structure of the UI Component](images/UiClassDiagram.png)
![Structure of the UI Component](images/UIClassDiagram.png)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm is this image name correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, fixed!

Copy link
Collaborator

@jeannetoh99 jeannetoh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lyeyixian lyeyixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@underthehai underthehai merged commit 557e1e3 into AY2021S1-CS2103-T14-3:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants