Show Total Cost in UI #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaweiteo
requested review from
jeannetoh99,
lyeyixian,
underthehai and
timjkong
Closed
lyeyixian
reviewed
Oct 27, 2020
| @@ -234,6 +234,7 @@ public void setTravelPlanObject(TravelPlanObject target, TravelPlanObject edited | |||
| requireAllNonNull(target, editedTravelPlanObject); | |||
| assert directory instanceof TravelPlan : "Directory must be set to a TravelPlan to call setTravelPlanObject."; | |||
| TravelPlan tp = (TravelPlan) directory; | |||
| Directory d = tp; | |||
There was a problem hiding this comment.
What does this line suppose to do?
| private final Logger logger = LogsCenter.getLogger(TravelPlanPanel.class); | ||
|
|
||
| private Directory directory; | ||
|
|
||
| private Logic logic; |
There was a problem hiding this comment.
Why do you need logic here tho? Doesn't seem to be used anywhere in the changes in this class?
| @@ -39,11 +46,16 @@ public TravelPlanPanel(Directory directory) { | |||
| public void update() { | |||
| if (directory instanceof TravelPlan) { | |||
| TravelPlan travelPlan = (TravelPlan) directory; | |||
| String cost = travelPlan.getTotalCost(); | |||
There was a problem hiding this comment.
Now no need do typecasting already. You can add this getTotalCost() method into Directory class.
There was a problem hiding this comment.
But still need to check isTravelPlan() to setText lah
| @@ -85,6 +87,7 @@ public void setAllTabsVisible() { | |||
| @Override | |||
| protected void updateItem(Activity activity, boolean empty) { | |||
| super.updateItem(activity, empty); | |||
| travelPlanPanel.update(); | |||
There was a problem hiding this comment.
Is calling the update() here suitable?
| @@ -159,6 +159,15 @@ private void handleDirectoryChange(Directory directory) { | |||
| } | |||
| } | |||
|
|
|||
| private void handleCostChange(Directory directory) { | |||
There was a problem hiding this comment.
I think the travelPlanPanel.update() can be called here instead? So, no need to pass into TravelPlanObjectListPanel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.