Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DG] Delete Command #173

Merged
merged 2 commits into from
Oct 27, 2020
Merged

[DG] Delete Command #173

merged 2 commits into from
Oct 27, 2020

Conversation

jiaweiteo
Copy link

No description provided.

@jiaweiteo jiaweiteo added this to the v1.4 milestone Oct 25, 2020
@lyeyixian lyeyixian linked an issue Oct 25, 2020 that may be closed by this pull request
Update DG: Delete #127
Closed
@lyeyixian lyeyixian modified the milestones: v1.4, v1.3 Oct 25, 2020
lyeyixian
lyeyixian approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@lyeyixian lyeyixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assumed the DG is correct XD. Same as before you whole branch will be merged if you merged this first

@jiaweiteo jiaweiteo merged commit ee2a861 into AY2021S1-CS2103-T14-3:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyeyixian lyeyixian lyeyixian approved these changes

@jeannetoh99 jeannetoh99 Awaiting requested review from jeannetoh99

@underthehai underthehai Awaiting requested review from underthehai

@timjkong timjkong Awaiting requested review from timjkong

Assignees
No one assigned
Labels
priority.Medium
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Update DG: Delete
2 participants
@jiaweiteo @lyeyixian