[UG] Update Find Command #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jiaweiteo
approved these changes
Oct 26, 2020
docs/UserGuide.md
Outdated
| @@ -58,6 +63,7 @@ Command | Parameters | Description | |||
| `delete -OBJECT` | `OBJECT` activity/ accommodation/ person/ travelplan | Deletes the given object type | |||
| `edit -OBJECT` | `OBJECT` activity/ accommodation/ person/ travelplan | Edits the details of the given object type | |||
| `goto PLAN_NAME` | `PLAN_NAME` nameOfTravelPlan/ wishlist | Navigate to the specific travel plan/ wishlist | |||
| `find -OBJECT` | `OBJECT` activity/ accommodation/ person | Finds the given object type whose names contain any of the given keywords | |||
There was a problem hiding this comment.
i think for all the find command in the table, we should change to COMMAND -OBJECT KEYWORD, then the parameters add in KEYWORD find object that contains this keyword
There was a problem hiding this comment.
I did this for my delete command, think we shld do it for all commands on the table. Add the additional parameter for the commands that require it. Like delete -object index
underthehai
reviewed
Oct 27, 2020
docs/UserGuide.md
Outdated
| @@ -58,6 +63,7 @@ Command | Parameters | Description | |||
| `delete -OBJECT` | `OBJECT` activity/ accommodation/ person/ travelplan | Deletes the given object type | |||
| `edit -OBJECT` | `OBJECT` activity/ accommodation/ person/ travelplan | Edits the details of the given object type | |||
| `goto PLAN_NAME` | `PLAN_NAME` nameOfTravelPlan/ wishlist | Navigate to the specific travel plan/ wishlist | |||
| `find -OBJECT KEYWORD` | `OBJECT` activity/ accommodation/ person<br/> `KEYWORD` keywords to search for | Finds the given object type whose names contain any of the given keywords | |||
There was a problem hiding this comment.
find friend instead of person?
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
============================================
- Coverage 66.17% 65.92% -0.26%
- Complexity 766 768 +2
============================================
Files 116 116
Lines 2510 2512 +2
Branches 309 307 -2
============================================
- Hits 1661 1656 -5
- Misses 724 733 +9
+ Partials 125 123 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.