Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defensive] EditCommand #178

Merged

Conversation

underthehai
Copy link
Collaborator

Update checks for valid tags and index
Update error messages

@underthehai underthehai added this to the v1.3 milestone Oct 27, 2020
@underthehai underthehai linked an issue Oct 27, 2020 that may be closed by this pull request
@underthehai underthehai changed the title [Defensive] edit command [Defensive] EditCommand Oct 27, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #178 into master will increase coverage by 0.49%.
The diff coverage is 47.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
+ Coverage     59.83%   60.33%   +0.49%     
- Complexity      794      803       +9     
============================================
  Files           126      126              
  Lines          2806     2801       -5     
  Branches        353      361       +8     
============================================
+ Hits           1679     1690      +11     
+ Misses          983      961      -22     
- Partials        144      150       +6     
Impacted Files Coverage Δ Complexity Δ
...s/logic/command/edit/EditAccommodationCommand.java 79.41% <0.00%> (-4.97%) 12.00 <0.00> (ø)
.../seedu/address/logic/command/edit/EditCommand.java 60.00% <ø> (ø) 1.00 <0.00> (ø)
.../address/logic/command/edit/EditFriendCommand.java 75.86% <0.00%> (-5.62%) 12.00 <0.00> (ø)
...ress/logic/command/edit/EditTravelPlanCommand.java 83.87% <0.00%> (-5.79%) 12.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 42.59% <ø> (ø) 9.00 <0.00> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 50.00% <48.00%> (+12.50%) 5.00 <2.00> (ø)
...ddress/logic/command/edit/EditActivityCommand.java 77.14% <66.66%> (+2.14%) 12.00 <0.00> (ø)
...edu/address/logic/command/edit/EditDescriptor.java 60.86% <66.66%> (+5.05%) 31.00 <4.00> (+6.00)
...rc/main/java/seedu/address/model/ModelManager.java 66.66% <0.00%> (+0.72%) 38.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5260b3...a161495. Read the comment docs.

Copy link
Collaborator

@timjkong timjkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jeannetoh99 jeannetoh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiaweiteo jiaweiteo removed this from the v1.3 milestone Oct 28, 2020
@lyeyixian lyeyixian added this to the v1.4 milestone Oct 28, 2020
@jeannetoh99 jeannetoh99 merged commit b53bc1a into AY2021S1-CS2103-T14-3:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Defensive] Edit Command
6 participants