Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D] sort -friend name #202

Closed
nus-pe-bot opened this issue Oct 30, 2020 · 0 comments · Fixed by #241
Closed

[PE-D] sort -friend name #202

nus-pe-bot opened this issue Oct 30, 2020 · 0 comments · Fixed by #241
Milestone
v1.4

Comments

@nus-pe-bot
Copy link

Since sort -friend only can sort by name, I think it may not be necessary to include name there unless you guys are planning to include more features to sort by :)

Labels: severity.Medium type.FeatureFlaw
original: kormingsoon/ped#10
jeannetoh99 added a commit to jeannetoh99/tp that referenced this issue Nov 1, 2020
@jeannetoh99
Resolve bugs, add and update features
3064923 
Resolve the following bugs:
1. Check for duplicates in edit, move and copy commands

Add the following features:
1. Auto Tab after add/edit/delete command

Update the following features:
1. Change isSameFriend to check for passport number only AY2021S1-CS2103-T14-3#222
2. Include sort -friend passport and mobile AY2021S1-CS2103-T14-3#202
3. Sort activity by most importance ones first instead of least important AY2021S1-CS2103-T14-3#224
4. Change isSameActivity to check for name, date and location AY2021S1-CS2103-T14-3#235
@jeannetoh99 jeannetoh99 mentioned this issue Nov 1, 2020
Merged
@jeannetoh99 jeannetoh99 linked a pull request Nov 1, 2020 that will close this issue
Resolve bugs, add and update features #241
Merged
@jeannetoh99 jeannetoh99 added this to the v1.4 milestone Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Resolve bugs, add and update features jeannetoh99/tp
2 participants
@jeannetoh99 @nus-pe-bot