Resolve bugs, add and update features #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve the following bugs: 1. Check for duplicates in edit, move and copy commands Add the following features: 1. Auto Tab after add/edit/delete command Update the following features: 1. Change isSameFriend to check for passport number only AY2021S1-CS2103-T14-3#222 2. Include sort -friend passport and mobile AY2021S1-CS2103-T14-3#202 3. Sort activity by most importance ones first instead of least important AY2021S1-CS2103-T14-3#224 4. Change isSameActivity to check for name, date and location AY2021S1-CS2103-T14-3#235
jeannetoh99
requested review from
underthehai,
timjkong,
jiaweiteo and
lyeyixian
and removed request for
underthehai
This was
linked to
issues
Nov 1, 2020
underthehai
approved these changes
Nov 1, 2020
src/main/java/seedu/address/model/travelplan/exceptions/DuplicateTravelPlanException.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Nov 1, 2020
lyeyixian
reviewed
Nov 3, 2020
| @@ -51,15 +52,15 @@ public Mobile getMobile() { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns true if both friends are of the same name | |||
| * Returns true if both friends have the same passport or same mobile. | |||
There was a problem hiding this comment.
This doesn't include mobile isn't it?
lyeyixian
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the following bugs:
Add the following features:
Update the following features: