Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Input cost exceeding MAX_INT #243

Merged
merged 12 commits into from
Nov 4, 2020

Conversation

lyeyixian
Copy link
Collaborator

No description provided.

@lyeyixian lyeyixian added this to the v1.4 milestone Nov 1, 2020
@lyeyixian lyeyixian linked an issue Nov 1, 2020 that may be closed by this pull request
@lyeyixian lyeyixian linked an issue Nov 1, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #243 into master will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #243      +/-   ##
============================================
- Coverage     60.33%   60.29%   -0.05%     
- Complexity      803      805       +2     
============================================
  Files           126      126              
  Lines          2801     2803       +2     
  Branches        361      361              
============================================
  Hits           1690     1690              
- Misses          961      963       +2     
  Partials        150      150              
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/address/model/commons/Cost.java 69.23% <33.33%> (-12.59%) 9.00 <3.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eba787...f61a650. Read the comment docs.

Copy link

@jiaweiteo jiaweiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lyeyixian lyeyixian merged commit 241a60d into AY2021S1-CS2103-T14-3:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D] Failed to check the cost integer overflow [PE-D] Extreme Number Input for Cost
3 participants