[BUG] Update mobile and passport regex #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=========================================
Coverage 60.33% 60.33%
Complexity 803 803
=========================================
Files 126 126
Lines 2801 2801
Branches 361 361
=========================================
Hits 1690 1690
Misses 961 961
Partials 150 150
Continue to review full report at Codecov.
|
This was
linked to
issues
Nov 1, 2020
lyeyixian
changed the title
underthehai
approved these changes
Nov 3, 2020
| @@ -23,7 +23,7 @@ | |||
| + "Example: " + COMMAND_WORD + " " | |||
| + PREFIX_NAME + "John Doe " | |||
| + PREFIX_MOBILE + "91234567 " | |||
| + PREFIX_PASSPORT + "p12345678 "; | |||
| + PREFIX_PASSPORT + "P1234567 "; | |||
There was a problem hiding this comment.
I think passport should end with a character
jiaweiteo
approved these changes
Nov 3, 2020
| new Friend(new Name("Bernice Yu"), new Passport("E1234567"), new Mobile("99272758")), | ||
| new Friend(new Name("Charlotte Oliveiro"), new Passport("C1234567"), new Mobile("93210283")), | ||
| new Friend(new Name("David Li"), new Passport("D1234567"), new Mobile("99103182")) | ||
| new Friend(new Name("Alex Yeoh"), new Passport("S1234567R"), new Mobile("87438807")), |
There was a problem hiding this comment.
huh? It's not [STFG] ?
# Conflicts: # src/main/java/seedu/address/logic/command/add/AddFriendCommand.java
…to bug-mobile-regex # Conflicts: # src/main/java/seedu/address/logic/command/add/AddFriendCommand.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.