Show command review #265
Show command review #265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
============================================
+ Coverage 60.60% 61.25% +0.65%
- Complexity 823 832 +9
============================================
Files 126 126
Lines 2894 2891 -3
Branches 384 383 -1
============================================
+ Hits 1754 1771 +17
+ Misses 976 957 -19
+ Partials 164 163 -1
Continue to review full report at Codecov.
|
| String[] keywords = args.split(" "); | ||
| if (keywords.length != ShowCommand.COMMAND_TOKENS) { |
There was a problem hiding this comment.
Nice way to work around the magic numbers! @timjkong @underthehai
|
|
||
| public class ShowCommandTest { | ||
|
|
||
| private Model model; |
There was a problem hiding this comment.
Maybe consider using a stub?
There was a problem hiding this comment.
Or is it suppose to use original model?
There was a problem hiding this comment.
Try out integration testing? haha
| @@ -18,12 +45,112 @@ public void execute_show_success() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void execute_goto_failure() { | |||
| public void execute_showAccommodation_success() { | |||
| try { | |||
There was a problem hiding this comment.
I wonder why you didn't use the method in CommandTestUtil (assertCommandSuccess(), etc.)?
Increased test coverage for show command to 90%