Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes #291

Merged
merged 5 commits into from
Nov 8, 2020
Merged

Bug Fixes #291

merged 5 commits into from
Nov 8, 2020

Conversation

jeannetoh99
Copy link
Collaborator

No description provided.

@jeannetoh99 jeannetoh99 changed the title Check for GotoCommand tokens Bug Fixes Nov 8, 2020
Copy link

@jiaweiteo jiaweiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lyeyixian lyeyixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #291 (0181398) into master (42d6296) will decrease coverage by 0.04%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #291      +/-   ##
============================================
- Coverage     70.54%   70.49%   -0.05%     
  Complexity      956      956              
============================================
  Files           126      126              
  Lines          2899     2901       +2     
  Branches        386      387       +1     
============================================
  Hits           2045     2045              
- Misses          677      678       +1     
- Partials        177      178       +1     
Impacted Files Coverage Δ Complexity Δ
...main/java/seedu/address/commons/core/Messages.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/logic/command/GoToCommand.java 86.95% <ø> (ø) 10.00 <0.00> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 41.37% <ø> (ø) 9.00 <0.00> (ø)
src/main/java/seedu/address/ui/UiManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../seedu/address/logic/parser/GoToCommandParser.java 88.23% <60.00%> (-11.77%) 6.00 <0.00> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 72.22% <100.00%> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d6296...0181398. Read the comment docs.

@jeannetoh99 jeannetoh99 merged commit 39199e8 into AY2021S1-CS2103-T14-3:master Nov 8, 2020
@jeannetoh99 jeannetoh99 added this to the v1.4 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants