-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Use Case #45
Update Use Case #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor change to be made I think
docs/DeveloperGuide.md
Outdated
* **Person**: Contains information about a given person `name`, `mobile number` and `passport number` | ||
* **Directory**: The three possible directories are `top`, `travelplan`, `wishlist` | ||
* **Navigate**: Use the `goto` command to move between directories | ||
* **View**: A command that provides a list of specified items |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think the command is called 'show' instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap, I will change it to show
|
||
**Extensions** | ||
|
||
* 1a. User is at the top directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit not sure about this. Is it we can edit the travel plan at top directory also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that since we can view the travel plans at the top directory, we can also modify the start and end date there too. Or is it better to restrict the editing to within travel plan directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dk hahaha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is ok but we should have a command to edit start and end date within travel plan directory also if not it might be a bit confusing
Add UC11 to UC17 and glossary to DeveloperGuide.md. Edited some parts of edit command under UserGuide.md.
close #41 #43