Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Use Case #45

Merged
merged 8 commits into from
Sep 27, 2020
Merged

Conversation

underthehai
Copy link
Collaborator

Add UC11 to UC17 and glossary to DeveloperGuide.md. Edited some parts of edit command under UserGuide.md.

close #41 #43

Copy link

@jiaweiteo jiaweiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor change to be made I think

* **Person**: Contains information about a given person `name`, `mobile number` and `passport number`
* **Directory**: The three possible directories are `top`, `travelplan`, `wishlist`
* **Navigate**: Use the `goto` command to move between directories
* **View**: A command that provides a list of specified items

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the command is called 'show' instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, I will change it to show


**Extensions**

* 1a. User is at the top directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit not sure about this. Is it we can edit the travel plan at top directory also?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that since we can view the travel plans at the top directory, we can also modify the start and end date there too. Or is it better to restrict the editing to within travel plan directory?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dk hahaha

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is ok but we should have a command to edit start and end date within travel plan directory also if not it might be a bit confusing

@underthehai underthehai merged commit b5747a2 into AY2021S1-CS2103-T14-3:master Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Use Cases in DeveloperGuide
4 participants