-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ui with sample data only #81
Conversation
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
=========================================
Coverage ? 38.01%
Complexity ? 400
=========================================
Files ? 121
Lines ? 2336
Branches ? 273
=========================================
Hits ? 888
Misses ? 1416
Partials ? 32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just some minor things that I think can be changed
Ui is not yet linked with logic for now, but is viewable with sample data/stubs. Added SampleWanderlustDataUtil for testing. Also edited some of the VALIDATION_REGEX of classes under model as previous ones were not working as expected when tested.