Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ui with sample data only #81

Merged
merged 15 commits into from
Oct 7, 2020

Conversation

jeannetoh99
Copy link
Collaborator

Ui is not yet linked with logic for now, but is viewable with sample data/stubs. Added SampleWanderlustDataUtil for testing. Also edited some of the VALIDATION_REGEX of classes under model as previous ones were not working as expected when tested.

@jeannetoh99 jeannetoh99 linked an issue Oct 6, 2020 that may be closed by this pull request
@jeannetoh99 jeannetoh99 added this to the v1.2 milestone Oct 6, 2020
@codecov-io
Copy link

codecov-io commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a5e8add). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #81   +/-   ##
=========================================
  Coverage          ?   38.01%           
  Complexity        ?      400           
=========================================
  Files             ?      121           
  Lines             ?     2336           
  Branches          ?      273           
=========================================
  Hits              ?      888           
  Misses            ?     1416           
  Partials          ?       32           
Impacted Files Coverage Δ Complexity Δ
...s/model/accommodation/UniqueAccommodationList.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...in/java/seedu/address/model/activity/Activity.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../java/seedu/address/model/activity/Importance.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...edu/address/model/activity/UniqueActivityList.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...edu/address/model/activity/WanderlustDateTime.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rc/main/java/seedu/address/model/commons/Cost.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...rc/main/java/seedu/address/model/commons/Name.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...va/seedu/address/model/commons/WanderlustDate.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...a/seedu/address/model/friend/UniqueFriendList.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...du/address/model/travelplan/AccommodationList.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5e8add...9433e48. Read the comment docs.

Copy link
Collaborator

@lyeyixian lyeyixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some minor things that I think can be changed

@jeannetoh99 jeannetoh99 merged commit f10deaa into AY2021S1-CS2103-T14-3:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI
3 participants