Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage package #82

Merged
merged 17 commits into from
Oct 7, 2020
Merged

Update storage package #82

merged 17 commits into from
Oct 7, 2020

Conversation

lyeyixian
Copy link
Collaborator

Almost done, just waiting for @jiaweiteo WanderlustDateTime

@lyeyixian
Merge branch 'master' of https://github.com/AY2021S1-CS2103-T14-3/tp
0f512c2
@lyeyixian
Add Storage, TravelPlannerStorage, UserPrefsStorage interface
9192259
@lyeyixian
Add StorageManager class
02ff7c3
@lyeyixian
Add JsonUserPrefsStorage class
284ab72
@lyeyixian
Add JsonSerializableTravelPlanner class
3ee0529
@lyeyixian
Add a String field to WanderlustDate
0023040 
JsonAdaptedTravelPlan in Storage package
@lyeyixian
Update the constructor of TravelPlan to take ActivityList instead of …
14a2c57 
…ReadOnlyActivityList

Same for the other 2 parameters, to be used in JsonAdaptedTravelPlan in Storage package
@lyeyixian
Update startDate and endDate field in Accommodation class to use Wand…
933b38b 
…erlustDate
@lyeyixian
Add JsonSerializableTravelPlanner class
f6e68d8
@lyeyixian
Add JsonAdaptedTravelPlan class
c9df507
@lyeyixian
Add JsonAdaptedFriend class
eebaef9
@lyeyixian
Add JsonAdaptedAccommodation class
536b849
@lyeyixian
Update toModelType method
e63c357
@lyeyixian
Add JsonAdaptedActivity class
51a7216
@lyeyixian lyeyixian added this to the v1.2 milestone Oct 7, 2020
@lyeyixian lyeyixian added this to In progress in v1.2 via automation Oct 7, 2020
@lyeyixian lyeyixian linked an issue Oct 7, 2020 that may be closed by this pull request
Update Storage #64
Closed
jeannetoh99
jeannetoh99 approved these changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@jeannetoh99 jeannetoh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiaweiteo
jiaweiteo approved these changes Oct 7, 2020
View reviewed changes
Copy link

@jiaweiteo jiaweiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiaweiteo jiaweiteo merged commit a5e8add into AY2021S1-CS2103-T14-3:master Oct 7, 2020
v1.2 automation moved this from In progress to Done Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeannetoh99 jeannetoh99 jeannetoh99 approved these changes

@jiaweiteo jiaweiteo jiaweiteo approved these changes

@timjkong timjkong Awaiting requested review from timjkong

@underthehai underthehai Awaiting requested review from underthehai

Assignees
No one assigned
Labels
None yet
Projects
v1.2
Done
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Update Storage
3 participants
@lyeyixian @jeannetoh99 @jiaweiteo