Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add command #89

Merged
merged 8 commits into from
Oct 10, 2020
Merged

Conversation

timjkong
Copy link
Collaborator

@timjkong timjkong commented Oct 8, 2020

Rename Phone class to Mobile in package seedu.address.model.friend
Add AddCommand classes in package seedu.address.logic.wanderlustlogic.wanderlustparser
Update WanderlustAddCommandParser
Update ParserUtil class in package seedu.address.logic.wanderlustlogic.wanderlustparser

Add AddCommand classes in package seedu.address.logic.wanderlustlogic.wanderlustparser
Update WanderlustAddCommandParser
Update ParserUtil class in package seedu.address.logic.wanderlustlogic.wanderlustparser
Add AddCommand classes in package seedu.address.logic.wanderlustlogic.wanderlustparser
Update WanderlustAddCommandParser
Update ParserUtil class in package seedu.address.logic.wanderlustlogic.wanderlustparser
Add AddCommand classes in package seedu.address.logic.wanderlustlogic.wanderlustparser
Update WanderlustAddCommandParser
Update ParserUtil class in package seedu.address.logic.wanderlustlogic.wanderlustparser
@jeannetoh99 jeannetoh99 linked an issue Oct 8, 2020 that may be closed by this pull request
@jeannetoh99 jeannetoh99 added this to the v1.2 milestone Oct 8, 2020
@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #89 into master will decrease coverage by 1.79%.
The diff coverage is 5.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #89      +/-   ##
============================================
- Coverage     44.73%   42.94%   -1.80%     
  Complexity      602      602              
============================================
  Files           148      153       +5     
  Lines          2754     2869     +115     
  Branches        332      351      +19     
============================================
  Hits           1232     1232              
- Misses         1453     1568     +115     
  Partials         69       69              
Impacted Files Coverage Δ Complexity Δ
...anderlustcommands/add/AddAccommodationCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...gic/wanderlustcommands/add/AddActivityCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...erlustlogic/wanderlustcommands/add/AddCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...logic/wanderlustcommands/add/AddFriendCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...c/wanderlustcommands/add/AddTravelPlanCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ic/wanderlustlogic/wanderlustparser/CliSyntax.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/wanderlustlogic/wanderlustparser/ParserUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...c/wanderlustparser/WanderlustAddCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../wanderlustparser/WanderlustEditCommandParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../java/seedu/address/model/activity/Importance.java 66.66% <ø> (ø) 4.00 <0.00> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a1276...96fd73e. Read the comment docs.

Copy link

@jiaweiteo jiaweiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeannetoh99 jeannetoh99 merged commit 5d9ab2f into AY2021S1-CS2103-T14-3:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update AddCommand
4 participants