Delete command test, parser test and other descriptionbuilders #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/seedu/address/model/travelplanner/Directory.java # src/main/java/seedu/address/model/travelplanner/Model.java # src/main/java/seedu/address/model/travelplanner/ModelManager.java # src/test/java/seedu/address/model/activity/ActivityTest.java # src/test/java/seedu/address/model/activity/UniqueActivityListTest.java # src/test/java/seedu/address/model/commons/NameContainsKeywordsPredicateTest.java
# Conflicts: # src/main/java/seedu/address/logic/wanderlustlogic/wanderlustcommands/EditCommand.java
jiaweiteo
requested review from
jeannetoh99,
lyeyixian,
underthehai and
timjkong
underthehai
reviewed
Oct 12, 2020
| EditActivityCommand command = (EditActivityCommand) parser.parseCommand(EditCommand.COMMAND_WORD | ||
| + " -activity " + INDEX_FIRST_TRAVELPLAN.getOneBased() + " " | ||
| + ActivityUtil.getEditActivityDescriptorDetails(descriptor)); | ||
| assertEquals(new EditActivityCommand(INDEX_FIRST_TRAVELPLAN, descriptor), command); |
There was a problem hiding this comment.
I think it is throwing an exception because the edit command ensures that at least one field is edited but the command and builder is building the exact same fields so there wasn't any editing done
underthehai
reviewed
Oct 12, 2020
|
|
||
| TravelPlan tp = model.getFilteredTravelPlanList().get(targetIndex.getZeroBased()); | ||
| final String[] splitName = tp.getName().name.split("\\s+"); | ||
| model.updateFilteredTravelPlanList(new NameContainsKeywordsPredicate(Arrays.asList(splitName[0]))); |
There was a problem hiding this comment.
Is it because maybe more than 1 travel plans can have the same first name?
lyeyixian
approved these changes
Oct 13, 2020
| /** | ||
| * Tests that a {@code TravelPlanObject}'s or {@code TravelPlan}'s {@code Name} matches any of the keywords given. | ||
| */ | ||
| public class NameContainsKeywordsPredicate implements Predicate<Object> { | ||
| public class NameContainsKeywordsPredicate implements Predicate<TravelPlan> { |
There was a problem hiding this comment.
Why this one change back to TravelPlan? It's not used in other place meh? like Activity all that
| * @param travelPlanObject object to be tested. | ||
| * @return true or false. | ||
| */ | ||
| public boolean test(TravelPlanObject travelPlanObject) { |
There was a problem hiding this comment.
Oh I see what you did there. Works but I feel like it is not following some OOP shit or smth. But I think we come back to this later ba.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing some testcases still and not sure why.
Main problem of failure is this method:
where the updateFilteredTravelPlanList cant seem to filter out 1 object, so the assertEquals led to false.