Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SavePresetCommand testcases #212

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

MorningLit
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #212 into master will increase coverage by 1.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #212      +/-   ##
============================================
+ Coverage     62.53%   63.88%   +1.34%     
- Complexity      692      705      +13     
============================================
  Files           118      118              
  Lines          2453     2453              
  Branches        283      283              
============================================
+ Hits           1534     1567      +33     
+ Misses          813      780      -33     
  Partials        106      106              
Impacted Files Coverage Δ Complexity Δ
...va/seedu/address/logic/commands/CommandResult.java 68.18% <ø> (ø) 8.00 <0.00> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 72.97% <100.00%> (+0.90%) 38.00 <1.00> (+1.00)
...ain/java/seedu/address/storage/StorageManager.java 72.50% <100.00%> (+20.00%) 14.00 <0.00> (+4.00)
...eedu/address/storage/JsonPresetManagerStorage.java 90.47% <0.00%> (+4.76%) 7.00% <0.00%> (+1.00%)
...eedu/address/logic/commands/SavePresetCommand.java 86.66% <0.00%> (+76.66%) 10.00% <0.00%> (+7.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98dae80...c663285. Read the comment docs.

Copy link

@ernestlim8 ernestlim8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestlim8 ernestlim8 merged commit d5bdbcf into AY2021S1-CS2103-T16-1:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants