Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for tag and untag command #218

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

ernestlim8
Copy link

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #218 into master will increase coverage by 2.29%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #218      +/-   ##
============================================
+ Coverage     64.00%   66.29%   +2.29%     
- Complexity      707      728      +21     
============================================
  Files           118      118              
  Lines          2456     2451       -5     
  Branches        284      287       +3     
============================================
+ Hits           1572     1625      +53     
+ Misses          777      713      -64     
- Partials        107      113       +6     
Impacted Files Coverage Δ Complexity Δ
.../java/seedu/address/logic/commands/TagCommand.java 65.00% <0.00%> (-11.48%) 5.00 <1.00> (+1.00) ⬇️
...ava/seedu/address/logic/commands/UntagCommand.java 66.66% <0.00%> (-8.34%) 5.00 <1.00> (+1.00) ⬇️
src/main/java/seedu/address/model/menu/Menu.java 92.98% <ø> (+15.04%) 26.00 <0.00> (ø)
...a/seedu/address/logic/parser/TagCommandParser.java 100.00% <100.00%> (+100.00%) 4.00 <0.00> (+4.00)
...seedu/address/logic/parser/UntagCommandParser.java 100.00% <100.00%> (+100.00%) 2.00 <0.00> (+2.00)
...rc/main/java/seedu/address/model/ModelManager.java 74.77% <0.00%> (+1.80%) 39.00% <0.00%> (+1.00%)
...in/java/seedu/address/logic/parser/ParserUtil.java 92.68% <0.00%> (+3.65%) 34.00% <0.00%> (+2.00%)
...c/main/java/seedu/address/model/food/MenuItem.java 100.00% <0.00%> (+37.50%) 4.00% <0.00%> (+1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9df1abb...c733f2e. Read the comment docs.

Copy link

@MorningLit MorningLit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MorningLit MorningLit merged commit 22e9ff7 into AY2021S1-CS2103-T16-1:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants