Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Clear Command #69

Merged
merged 4 commits into from
Oct 18, 2020
Merged

Update Clear Command #69

merged 4 commits into from
Oct 18, 2020

Conversation

Anikesh99
Copy link

No description provided.

@Anikesh99 Anikesh99 added the enhancement New feature or request label Oct 18, 2020
@Anikesh99 Anikesh99 added this to the V1.3 milestone Oct 18, 2020
@Anikesh99 Anikesh99 self-assigned this Oct 18, 2020
@Anikesh99 Anikesh99 changed the title Clear Command Update Clear Command Oct 18, 2020
This was linked to issues Oct 18, 2020
As a user, I would like to clear my current order. #66
Closed
As a new user I wish to see usage instructions #31
Closed
@Anikesh99 Anikesh99 removed the enhancement New feature or request label Oct 18, 2020
ernestlim8
ernestlim8 reviewed Oct 18, 2020
View reviewed changes
src/test/java/seedu/address/logic/commands/ClearCommandTest.java Outdated
Model expectedModel = new ModelManager(getTypicalAddressBook(), new UserPrefs());
expectedModel.setOrderManager(new OrderManager());
model.setOrderManager(new OrderManager());
OrderItem instantiate = new OrderItem(new Food("Prata", 1, new HashSet<>()), 1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this OrderItem can be renamed to orderItem for better readibility?

ernestlim8
ernestlim8 approved these changes Oct 18, 2020
View reviewed changes
Copy link

@ernestlim8 ernestlim8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to rename the OrderItem variable name.

@codecov-io
Copy link

codecov-io commented Oct 18, 2020 •
edited

Codecov Report

Merging #69 into master will increase coverage by 1.12%.
The diff coverage is 90.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
+ Coverage     56.07%   57.19%   +1.12%     
- Complexity      440      452      +12     
============================================
  Files            93       94       +1     
  Lines          1762     1771       +9     
  Branches        178      180       +2     
============================================
+ Hits            988     1013      +25     
+ Misses          721      702      -19     
- Partials         53       56       +3
Impacted Files Coverage Δ Complexity Δ
...a/seedu/address/logic/parser/AddCommandParser.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/seedu/address/ui/HelpWindow.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...eedu/address/logic/parser/RemoveCommandParser.java 61.53% <60.00%> (ø) 2.00 <1.00> (?)
...ava/seedu/address/logic/commands/ClearCommand.java 100.00% <100.00%> (ø) 3.00 <0.00> (+1.00)
...va/seedu/address/logic/commands/RemoveCommand.java 100.00% <100.00%> (ø) 10.00 <2.00> (?)
.../seedu/address/logic/parser/AddressBookParser.java 78.94% <100.00%> (ø) 11.00 <0.00> (ø)
...seedu/address/logic/parser/ClearCommandParser.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
...rc/main/java/seedu/address/model/ModelManager.java 68.00% <100.00%> (+1.33%) 30.00 <1.00> (+2.00)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e02b4...d14e23e. Read the comment docs.

@ernestlim8 ernestlim8 merged commit 68d2853 into master Oct 18, 2020
@Anikesh99 Anikesh99 deleted the add-command branch October 18, 2020 07:16
@Anikesh99 Anikesh99 restored the add-command branch October 18, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestlim8 ernestlim8 ernestlim8 approved these changes

Assignees

@Anikesh99 Anikesh99

Labels
None yet
Projects
None yet
Milestone
V1.3
Development

Successfully merging this pull request may close these issues.

As a user, I would like to clear my current order. As a new user I wish to see usage instructions
3 participants
@Anikesh99 @codecov-io @ernestlim8