Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VendorCommand and Menu #86

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

ernestlim8
Copy link

Fix bugs with UI not displaying message when command is executed successfully.
Fix Command tests after refactoring.
Add new feature where the current order is cleared when the vendor command changes to a new vendor.

@ernestlim8 ernestlim8 added this to the V1.3 milestone Oct 21, 2020
@ernestlim8 ernestlim8 added bug Something isn't working enhancement New feature or request labels Oct 21, 2020
@ernestlim8 ernestlim8 linked an issue Oct 21, 2020 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #86 into master will decrease coverage by 0.16%.
The diff coverage is 58.82%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     59.35%   59.19%   -0.17%     
- Complexity      517      518       +1     
============================================
  Files           101      101              
  Lines          1961     1968       +7     
  Branches        203      205       +2     
============================================
+ Hits           1164     1165       +1     
- Misses          728      733       +5     
- Partials         69       70       +1     
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/seedu/address/logic/LogicManager.java 61.11% <0.00%> (-3.89%) 3.00 <0.00> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/seedu/address/logic/commands/CommandResult.java 78.94% <80.00%> (-9.29%) 10.00 <3.00> (ø)
...java/seedu/address/logic/commands/ExitCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...java/seedu/address/logic/commands/HelpCommand.java 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...va/seedu/address/logic/commands/VendorCommand.java 100.00% <100.00%> (ø) 8.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098d75f...c571455. Read the comment docs.

Copy link

@MorningLit MorningLit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

@MorningLit MorningLit merged commit 5356959 into AY2021S1-CS2103-T16-1:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect vendor to menu
3 participants