Priority feature #121
Merged
Priority feature #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijavierja
reviewed
Oct 24, 2020
| case "undefined": | ||
| priorityShape.setBorder(new Border(new BorderStroke(ColorPicker.WHITE_BORDER, | ||
| BorderStrokeStyle.SOLID, CornerRadii.EMPTY, new BorderWidths(BORDER_SIZE)))); | ||
| priorityShape.setBackground(new Background(new BackgroundFill(Color.WHITE, CornerRadii.EMPTY, |
There was a problem hiding this comment.
Is there a difference between ColorPicker.WHITE_BORDER and Color.WHITE?
There was a problem hiding this comment.
Yes, there is, white border is slightly darker
WeiJie96
requested changes
Oct 25, 2020
| import javafx.scene.paint.Color; | ||
|
|
||
| /** | ||
| * Class for custom colors used for AB3, especially for the priorityShape |
|
I would feel theres a certain level of danger to this because there isnt tests written for these yet, but I assume its just the first iteration of it so yeah LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #85
Implemented Priority Feature with UI