Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG to include Archive feature #138

Merged
merged 5 commits into from
Oct 28, 2020

Conversation

WeiJie96
Copy link

No description provided.

@WeiJie96 WeiJie96 added this to the v1.3 milestone Oct 28, 2020
@WeiJie96 WeiJie96 assigned WeiJie96 and unassigned WeiJie96 Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #138 into master will increase coverage by 2.81%.
The diff coverage is 52.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #138      +/-   ##
============================================
+ Coverage     65.54%   68.35%   +2.81%     
- Complexity      483      562      +79     
============================================
  Files            89       93       +4     
  Lines          1660     1833     +173     
  Branches        197      218      +21     
============================================
+ Hits           1088     1253     +165     
+ Misses          507      499       -8     
- Partials         65       81      +16     
Impacted Files Coverage Δ Complexity Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...seedu/address/model/util/SampleClientDataUtil.java 18.75% <0.00%> (ø) 1.00 <0.00> (?)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...a/seedu/address/model/person/UniquePersonList.java 54.05% <6.06%> (-38.63%) 21.00 <1.00> (+1.00) ⬇️
.../java/seedu/address/logic/commands/AddCommand.java 58.06% <27.77%> (-41.94%) 10.00 <1.00> (+1.00) ⬇️
...edu/address/logic/commands/ClearPolicyCommand.java 28.57% <28.57%> (ø) 2.00 <2.00> (?)
...ain/java/seedu/address/storage/StorageManager.java 76.92% <37.50%> (-17.53%) 10.00 <1.00> (+1.00) ⬇️
...rc/main/java/seedu/address/logic/LogicManager.java 65.38% <50.00%> (-2.80%) 3.00 <0.00> (ø)
src/main/java/seedu/address/model/ClientList.java 85.71% <50.00%> (-5.96%) 13.00 <1.00> (+1.00) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d667c93...61fa305. Read the comment docs.

Copy link

@ijavierja ijavierja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijavierja ijavierja merged commit 5b4cafb into AY2021S1-CS2103-T16-2:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants