Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document archive in UG #108

Merged
merged 2 commits into from
Oct 25, 2020
Merged

Document archive in UG #108

merged 2 commits into from
Oct 25, 2020

Conversation

JingYenLoh
Copy link

@JingYenLoh JingYenLoh commented Oct 25, 2020

What this does

This PR documents the archive command that I added in #102 to our User Guide. I think I also fix our markdown table formatting, but I'm not very sure how GFM deals with tables, and I don't really want to dive into a manual investigation 馃槴

How to test

  1. Read the documentation I've written for the command and see if it's appropriate.

Notes

The sea is bright.

@JingYenLoh JingYenLoh added this to the v1.3 milestone Oct 25, 2020
@JingYenLoh JingYenLoh added this to To Do in ResiReg Kanban Board via automation Oct 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #108 into master will increase coverage by 8.94%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #108      +/-   ##
============================================
+ Coverage     60.80%   69.75%   +8.94%     
- Complexity      702      839     +137     
============================================
  Files           128      128              
  Lines          2610     2906     +296     
  Branches        308      379      +71     
============================================
+ Hits           1587     2027     +440     
+ Misses          939      765     -174     
- Partials         84      114      +30     
Impacted Files Coverage 螖 Complexity 螖
...java/seedu/resireg/logic/commands/RedoCommand.java 100.00% <0.00%> (酶) 7.00% <0.00%> (+3.00%)
...java/seedu/resireg/logic/commands/UndoCommand.java 100.00% <0.00%> (酶) 8.00% <0.00%> (+4.00%)
...a/seedu/resireg/logic/parser/AddCommandParser.java 100.00% <0.00%> (酶) 9.00% <0.00%> (+4.00%)
...du/resireg/logic/parser/AddAliasCommandParser.java 100.00% <0.00%> (酶) 9.00% <0.00%> (+4.00%)
...du/resireg/logic/parser/ListRoomCommandParser.java 100.00% <0.00%> (酶) 7.00% <0.00%> (+1.00%)
src/main/java/seedu/resireg/model/room/Room.java 70.27% <0.00%> (+2.70%) 18.00% <0.00%> (+1.00%)
...resireg/logic/parser/DeleteAliasCommandParser.java 11.11% <0.00%> (+2.77%) 2.00% <0.00%> (+1.00%)
...ain/java/seedu/resireg/logic/parser/CliSyntax.java 94.11% <0.00%> (+3.20%) 1.00% <0.00%> (酶%)
...java/seedu/resireg/logic/commands/EditCommand.java 90.37% <0.00%> (+3.31%) 24.00% <0.00%> (+12.00%)
.../seedu/resireg/logic/commands/ListRoomCommand.java 83.33% <0.00%> (+3.33%) 13.00% <0.00%> (+6.00%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 47db92c...5d74ac3. Read the comment docs.

Copy link

@jetnew jetnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jetnew jetnew merged commit 7d7a1a8 into master Oct 25, 2020
ResiReg Kanban Board automation moved this from To Do to Done Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants