Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG feature screenshots and profile #131

Merged
merged 4 commits into from
Oct 29, 2020

Conversation

jetnew
Copy link

@jetnew jetnew commented Oct 29, 2020

What this does

This PR updates the User Guide with Allocation feature screenshots and updates my profile.

How to test

  1. Navigate to the docs folder.
  2. Run bundle exec jekyll serve.

Notes

N/A

@jetnew jetnew added this to the v1.4 milestone Oct 29, 2020
@jetnew jetnew requested a review from Lysire October 29, 2020 14:11
@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #131 into master will decrease coverage by 3.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #131      +/-   ##
============================================
- Coverage     64.56%   61.42%   -3.14%     
- Complexity      949     1007      +58     
============================================
  Files           160      160              
  Lines          3381     3806     +425     
  Branches        403      458      +55     
============================================
+ Hits           2183     2338     +155     
- Misses         1073     1330     +257     
- Partials        125      138      +13     
Impacted Files Coverage Δ Complexity Δ
...eedu/resireg/logic/commands/ReallocateCommand.java 76.92% <0.00%> (-4.16%) 11.00 <0.00> (ø)
...java/seedu/resireg/storage/JsonAdaptedBinItem.java 75.92% <0.00%> (-8.69%) 7.00% <0.00%> (+1.00%) ⬇️
src/main/java/seedu/resireg/model/ResiReg.java 75.00% <0.00%> (-0.19%) 68.00% <0.00%> (+30.00%) ⬇️
src/main/java/seedu/resireg/MainApp.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
src/main/java/seedu/resireg/ui/MainPanel.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
src/main/java/seedu/resireg/ui/MainWindow.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...c/main/java/seedu/resireg/ui/BinItemListPanel.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...java/seedu/resireg/logic/commands/HelpCommand.java 100.00% <0.00%> (ø) 15.00% <0.00%> (+6.00%)
...ava/seedu/resireg/model/allocation/Allocation.java 67.64% <0.00%> (ø) 18.00% <0.00%> (+1.00%)
...rc/main/java/seedu/resireg/model/ModelManager.java 76.26% <0.00%> (+0.15%) 57.00% <0.00%> (+6.00%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60275c...467b071. Read the comment docs.

@jetnew jetnew self-assigned this Oct 29, 2020
Copy link
Collaborator

@mkeoliya mkeoliya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed requested.


##### After deallocation

<img src="https://user-images.githubusercontent.com/27071473/97580237-0040da00-1a2e-11eb-9337-f3bf29f85bed.png">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro put the image in our docs/images folder and use the markdown format to insert it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro it's "change(s)" requested not changed requested.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed maded

@JingYenLoh JingYenLoh merged commit 9913696 into master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants